Attention is currently required from: Anastasia Klimchuk, Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer.
Subrata Banik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/flashrom/+/82626?usp=email )
Change subject: flashchips: add support for MX77U51250F chip
......................................................................
Patch Set 3:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82626/comment/fd806f97_3cd9c316?usp... :
PS3, Line 11618: 65536
Yes, the Flash density is 64MB
Not sure if you can access https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+.... We don't plan to use 64MB flash out hence, we might need to fake this part to show the max capacity is 32MB. Flashing 64MB takes significantly higher time.
https://review.coreboot.org/c/flashrom/+/82626/comment/8d4bcdb4_d4459a53?usp... :
PS3, Line 11648: },
please add below details as well
.reg_bits =
{
...
}
.decode_range
I think user don't have to add this detail if they haven't test the write protection function for this Flash.
this is must for the ChromeOS device hence, asked to specify those details.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c
Gerrit-Change-Number: 82626
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 20 Jul 2024 06:12:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DZ
danielzhang@mxic.com.cn
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com