Attention is currently required from: Anastasia Klimchuk, Bora Guvendik, DZ, Nikolai Artemiev, Stefan Reinauer.
View Change
2 comments:
File flashchips.c:
Patch Set #3, Line 11618: 65536
Yes, the Flash density is 64MB
Not sure if you can access https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/3897831. We don't plan to use 64MB flash out hence, we might need to fake this part to show the max capacity is 32MB. Flashing 64MB takes significantly higher time.
Patch Set #3, Line 11648: },
please add below details as well
```
.reg_bits =
{
...
}
.decode_range
```
I think user don't have to add this detail if they haven't test the write protection function for this Flash.
this is must for the ChromeOS device hence, asked to specify those details.
To view, visit change 82626. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c
Gerrit-Change-Number: 82626
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: DZ <danielzhang@mxic.com.cn>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Attention: DZ <danielzhang@mxic.com.cn>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Sat, 20 Jul 2024 06:12:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DZ <danielzhang@mxic.com.cn>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>