Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62898 )
Change subject: hwaccess: replace macros by C code ......................................................................
Patch Set 5: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62898/comment/f103a0d4_9781ef2a PS5, Line 9: seperate sep*a*rate
https://review.coreboot.org/c/flashrom/+/62898/comment/9989fb7b_e4bea970 PS5, Line 11: endiannes one more `s`
https://review.coreboot.org/c/flashrom/+/62898/comment/e896baf1_f2a4162c PS5, Line 12: swaped another `p`, i.e. `swapped` also a lot in the code.
Patchset:
PS5: Looks ok to me. Maybe give people some time to comment before the next patch set :)
File hwaccess.h:
https://review.coreboot.org/c/flashrom/+/62898/comment/35da6b13_52c02bf7 PS5, Line 30: return ((value & (uint16_t)0x00ffU) << 8) | Maybe add another space after `return` for alignment?
https://review.coreboot.org/c/flashrom/+/62898/comment/2570e05a_faf5c6d6 PS5, Line 64: gets or `becomes` or in macro notion `expands to`?
I would also add a lot of whitespace, e.g. blank lines around this one. Somehow I managed to read the code to understand the comment :D
-
Nico Huber (Code Review)