Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk.
Patch set 5:Code-Review +1
6 comments:
Commit Message:
Patch Set #5, Line 9: seperate
sep*a*rate
Patch Set #5, Line 11: endiannes
one more `s`
Patch Set #5, Line 12: swaped
another `p`, i.e. `swapped` also a lot in the code.
Patchset:
Looks ok to me. Maybe give people some time to comment before the
next patch set :)
File hwaccess.h:
Patch Set #5, Line 30: return ((value & (uint16_t)0x00ffU) << 8) |
Maybe add another space after `return` for alignment?
or `becomes` or in macro notion `expands to`?
I would also add a lot of whitespace, e.g. blank lines around this one.
Somehow I managed to read the code to understand the comment :D
To view, visit change 62898. To unsubscribe, or for help writing mail filters, visit settings.