Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58357 )
Change subject: tests: Add tests to write on chip ......................................................................
Patch Set 2:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/58357/comment/07dcdd88_b89bf24b PS2, Line 270: flash
yes three lines in a row start with "struct flash...." :) […]
Although it would be nice to have `struct flashromctx ctx = { 0 };` sort of future, see https://github.com/flashrom/flashrom/blob/master/flash.h#L166
I think for now `struct flashrom_flashctx flashctx = { 0 }` seems at least consistent until that above TODO is resolved. It is also more clear to say "flashctx" than just "flash" since the 'ctx' part is actually the more relevant component than the 'flash' prefix.
-
Edward O'Callaghan (Code Review)