Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
File tests/chip.c:
Patch Set #2, Line 270: flash
yes three lines in a row start with "struct flash...." :) […]
Although it would be nice to have `struct flashromctx ctx = { 0 };` sort of future, see https://github.com/flashrom/flashrom/blob/master/flash.h#L166
I think for now `struct flashrom_flashctx flashctx = { 0 }` seems at least consistent until that above TODO is resolved. It is also more clear to say "flashctx" than just "flash" since the 'ctx' part is actually the more relevant component than the 'flash' prefix.
To view, visit change 58357. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6f0336613ab16a7e59857006496e3590ddb14d00
Gerrit-Change-Number: 58357
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 25 Oct 2021 23:25:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment