[M] Change in flashrom[master]: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
Attention is currently required from: Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash() ......................................................................
Patch Set 13:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/f0177a99_09c3aa40 PS13, Line 868: goto notfound;
Please a line after that
Done
File w29ee011.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/cdf54eb1_d3b07caa PS13, Line 25: override_chip || strcmp(override_chip, chip_name)
Just an idea, a nit: How about moving this to a variable `can_override`? This also would allow us ha […]
I think there is no need to be overly clever here and possibly make bugs unrelated to the objective of this patch. Marking as resolved.
-
Edward O'Callaghan (Code Review)