Attention is currently required from: Anastasia Klimchuk.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #13, Line 868: goto notfound;

    Please a line after that

    Done

• File w29ee011.c:

  • Patch Set #13, Line 25: override_chip || strcmp(override_chip, chip_name)

    Just an idea, a nit: How about moving this to a variable `can_override`? This also would allow us ha […]

    I think there is no need to be overly clever here and possibly make bugs unrelated to the objective of this patch. Marking as resolved.

To view, visit change 67091. To unsubscribe, or for help writing mail filters, visit settings.