Attention is currently required from: Thomas Heijligen, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB 3 XHCI flashing ......................................................................
Patch Set 11:
(4 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/bd9695ac_8b26fb87 PS3, Line 38: static struct pci_dev *dev = NULL;
The point I'm trying to make is that the `struct pci_dev *dev` should NOT be a global variable. […]
Here is my broken progress: https://gist.githubusercontent.com/CE1CECL/23ce4bab29bb0382da29ad48c049145c/...
dev is defined at the top because vl805_setregval, and vl805_getregval need it, and those are needed before vl805_getregval. So, I don't know, I think I'm missing something.
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/a4f41350_58416956 PS10, Line 103: static const struct spi_master spi_master_vl805 = {
Add `. […]
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/b2dfaa79_7e567b67 PS10, Line 120: static int vl805_shutdown(void *data)
This has to move above `struct spi_master`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/ad3afa97_f86ae719 PS10, Line 157: register_shutdown(vl805_shutdown, NULL);
The `register_shutdown()` can be removed. […]
Done
-
ChrisEric1 CECL (Code Review)