Attention is currently required from: Thomas Heijligen, Nicholas Chin.

View Change

4 comments:

• File vl805.c:

  • Patch Set #3, Line 38: static struct pci_dev *dev = NULL;

    The point I'm trying to make is that the `struct pci_dev *dev` should NOT be a global variable. […]

    Here is my broken progress: https://gist.githubusercontent.com/CE1CECL/23ce4bab29bb0382da29ad48c049145c/raw/0ad07bf836b66260f532d20296372a4007e6807c/vl805.c

    dev is defined at the top because vl805_setregval, and vl805_getregval need it, and those are needed before vl805_getregval. So, I don't know, I think I'm missing something.

• File vl805.c:

  • Patch Set #10, Line 103: static const struct spi_master spi_master_vl805 = {

    Add `. […]

    Done

  • Patch Set #10, Line 120: static int vl805_shutdown(void *data)

    This has to move above `struct spi_master`

    Done

  • Patch Set #10, Line 157: register_shutdown(vl805_shutdown, NULL);

    The `register_shutdown()` can be removed. […]

    Done

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.