[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 )
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ......................................................................
Patch Set 45:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/c05da115_8ec82c6e PS41, Line 1237: : struct erase_layout *create_erase_layout(struct flashctx *const flashctx); :
These prototyes here are temporary until the functions are used. […]
I can see what the prototypes are being used for but I don't think this is a good manner to deploy a large change. You could create a `erasure_layout.c` object and have a header for that and have the entry-points in `flashrom.c` switch between the old static implementation or the new one inside `erasure_layout.c`. Adding one function per commit that doesn't get called serves no real purpose.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/6c1a8064_12b100c2 PS42, Line 1249: index
Yeah `i` and `index` won't always be same.
maybe a better identifier than "index" and short hand for "i"ndex then?
-
Edward O'Callaghan (Code Review)