Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen, Paul Menzel, Aarya.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #41, Line 1237:

    
    struct erase_layout *create_erase_layout(struct flashctx *const flashctx);
    
    

    These prototyes here are temporary until the functions are used. […]

    I can see what the prototypes are being used for but I don't think this is a good manner to deploy a large change. You could create a `erasure_layout.c` object and have a header for that and have the entry-points in `flashrom.c` switch between the old static implementation or the new one inside `erasure_layout.c`. Adding one function per commit that doesn't get called serves no real purpose.

• File flashrom.c:

  • Patch Set #42, Line 1249: index

    Yeah `i` and `index` won't always be same.

    maybe a better identifier than "index" and short hand for "i"ndex then?

To view, visit change 65879. To unsubscribe, or for help writing mail filters, visit settings.