[M] Change in flashrom[master]: cli_classic: move validation of incompatible options to one place

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66532 )

Change subject: cli_classic: move validation of incompatible options to one place
......................................................................

Patch Set 6:

(2 comments)

Patchset:

PS6: 
Another note on testing: all the invalid combinations can be tested with dummy. Even the options which are not supported by dummy, because cli is expected to abort+message early and not call the programmer code.

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/66532/comment/37ca370b_0bfe61a7 
PS2, Line 560: validate_options(
> I think if the branches are all in here now then you will need to ensure this function is called con […]

I was thinking about it, this patch moves validation into `parse_options` which has to be called, because the options has to be parsed. Do you mean to ensure `validate_options` is called inside `parse_options`?