Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.

View Change

2 comments:

• Patchset:

  • Patch Set #6:

    Another note on testing: all the invalid combinations can be tested with dummy. Even the options which are not supported by dummy, because cli is expected to abort+message early and not call the programmer code.

• File cli_classic.c:

  • Patch Set #2, Line 560: validate_options(

    I think if the branches are all in here now then you will need to ensure this function is called con […]

    I was thinking about it, this patch moves validation into `parse_options` which has to be called, because the options has to be parsed. Do you mean to ensure `validate_options` is called inside `parse_options`?

To view, visit change 66532. To unsubscribe, or for help writing mail filters, visit settings.