Attention is currently required from: Anastasia Klimchuk, NyeonWoo Kim, Peter Marheine.
Dmitry Zhadinets has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87047?usp=email )
Change subject: libflashrom: Add set log level functionality ......................................................................
Patch Set 6:
(4 comments)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/87047/comment/1ed53918_472fe89a?usp... : PS6, Line 6: *
I think it's about time to add a line for yourself here, and in the header, you are doing significan […]
Done
https://review.coreboot.org/c/flashrom/+/87047/comment/19fffc33_8c0ef7ca?usp... : PS6, Line 36: enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
It doesn't look like this needs external linkage, so it should be `static`. […]
My bad. Done
File tests/libflashrom.c:
https://review.coreboot.org/c/flashrom/+/87047/comment/fcbc42b2_be0c5c1b?usp... : PS6, Line 66: (void)state; /* unused */ : int user_data = 100500; : flashrom_set_log_callback_v2(test_log_callback_v2, &user_data); : flashrom_set_log_level(FLASHROM_MSG_WARN);
For readability, could you please re-arrange lines a bit, and add few new lines: […]
Done
https://review.coreboot.org/c/flashrom/+/87047/comment/2a66a1ab_e050cc28?usp... : PS6, Line 91: /* check that callback is called after the change*/
maybe a new line between 90-91, again so that flashrom_set_log_level be easily visible
Done