Attention is currently required from: Anastasia Klimchuk, NyeonWoo Kim, Peter Marheine.

View Change

4 comments:

• File libflashrom.c:

  • Patch Set #6, Line 6: *

    I think it's about time to add a line for yourself here, and in the header, you are doing significan […]

    Done

  • Patch Set #6, Line 36: enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;

    It doesn't look like this needs external linkage, so it should be `static`. […]

    My bad. Done

• File tests/libflashrom.c:

  • Patch Set #6, Line 66:

    	(void)state; /* unused */
    	int user_data = 100500;
    	flashrom_set_log_callback_v2(test_log_callback_v2, &user_data);
    	flashrom_set_log_level(FLASHROM_MSG_WARN);
    

    For readability, could you please re-arrange lines a bit, and add few new lines: […]

    Done

  • Patch Set #6, Line 91: /* check that callback is called after the change*/

    maybe a new line between 90-91, again so that flashrom_set_log_level be easily visible

    Done

To view, visit change 87047. To unsubscribe, or for help writing mail filters, visit settings.