Change in ...flashrom[1.1.x]: Makefile: Also blacklist J-Link SPI for DOS

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33296

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Makefile: Also blacklist J-Link SPI for DOS

libjaylink will probably never be available.

Change-Id: Ie9222f82e16fe4c76fe7dd0f9aac7de6a862ab98
Signed-off-by: Nico Huber 
---
M Makefile
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/33296/1

diff --git a/Makefile b/Makefile
index 4d23c39..e08a3f6 100644
--- a/Makefile
+++ b/Makefile
@@ -190,6 +190,12 @@
 else
 override CONFIG_CH341A_SPI = no
 endif
+# libjaylink is also not available for DOS
+ifeq ($(CONFIG_JLINK_SPI), yes)
+UNSUPPORTED_FEATURES += CONFIG_JLINK_SPI=yes
+else
+override CONFIG_JLINK_SPI = no
+endif
 endif

# FIXME: Should we check for Cygwin/MSVC as well?

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1: Code-Review+2

libjaylink depends also on libusb, which is not available on DOS

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1: Code-Review+1
> Patch Set 1: Code-Review+2
>
> libjaylink depends also on libusb, which is not available on DOS

the README says it depends, the code says it's optional.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1:
> > libjaylink depends also on libusb, which is not available on DOS
>
> the README says it depends, the code says it's optional.

What exactly is optional? libusb? that doesn't change the
fact that it isn't available for DOS...

see `Portability` here: http://git.zapb.de/libjaylink.git/about/

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1: Code-Review+2

[Marc Schink (Code Review)]

Marc Schink has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1: Code-Review+1

libusb is indeed optional but I won't port it to DOS :D

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33296 )

Change subject: Makefile: Also blacklist J-Link SPI for DOS
......................................................................

Makefile: Also blacklist J-Link SPI for DOS

libjaylink will probably never be available.

Change-Id: Ie9222f82e16fe4c76fe7dd0f9aac7de6a862ab98
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/33296
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
Reviewed-by: Marc Schink 
Reviewed-by: Thomas Heijligen 
Reviewed-by: Angel Pons 
---
M Makefile
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Marc Schink: Looks good to me, but someone else must approve
  Thomas Heijligen: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/Makefile b/Makefile
index 4d23c39..e08a3f6 100644
--- a/Makefile
+++ b/Makefile
@@ -190,6 +190,12 @@
 else
 override CONFIG_CH341A_SPI = no
 endif
+# libjaylink is also not available for DOS
+ifeq ($(CONFIG_JLINK_SPI), yes)
+UNSUPPORTED_FEATURES += CONFIG_JLINK_SPI=yes
+else
+override CONFIG_JLINK_SPI = no
+endif
 endif

# FIXME: Should we check for Cygwin/MSVC as well?