Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33295
Change subject: Makefile: Blacklist Digilent SPI (using USB) for DOS ......................................................................
Makefile: Blacklist Digilent SPI (using USB) for DOS
Change-Id: I9a7dd5a2afcd12dd247e1f5534db61b79d77525e Signed-off-by: Nico Huber nico.h@gmx.de --- M Makefile 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/33295/1
diff --git a/Makefile b/Makefile index 1e7db3e..4d23c39 100644 --- a/Makefile +++ b/Makefile @@ -154,7 +154,12 @@ else override CONFIG_PONY_SPI = no endif -# Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under DOS (missing USB support). +# Digilent SPI, Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under DOS (missing USB support). +ifeq ($(CONFIG_DIGILENT_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_DIGILENT_SPI=yes +else +override CONFIG_DIGILENT_SPI = no +endif ifeq ($(CONFIG_DEDIPROG), yes) UNSUPPORTED_FEATURES += CONFIG_DEDIPROG=yes else
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33295 )
Change subject: Makefile: Blacklist Digilent SPI (using USB) for DOS ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33295 )
Change subject: Makefile: Blacklist Digilent SPI (using USB) for DOS ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33295 )
Change subject: Makefile: Blacklist Digilent SPI (using USB) for DOS ......................................................................
Makefile: Blacklist Digilent SPI (using USB) for DOS
Change-Id: I9a7dd5a2afcd12dd247e1f5534db61b79d77525e Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/flashrom/+/33295 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Thomas Heijligen src@posteo.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Makefile 1 file changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index 1e7db3e..4d23c39 100644 --- a/Makefile +++ b/Makefile @@ -154,7 +154,12 @@ else override CONFIG_PONY_SPI = no endif -# Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under DOS (missing USB support). +# Digilent SPI, Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under DOS (missing USB support). +ifeq ($(CONFIG_DIGILENT_SPI), yes) +UNSUPPORTED_FEATURES += CONFIG_DIGILENT_SPI=yes +else +override CONFIG_DIGILENT_SPI = no +endif ifeq ($(CONFIG_DEDIPROG), yes) UNSUPPORTED_FEATURES += CONFIG_DEDIPROG=yes else
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Thomas Heijligen (Code Review)