Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS4:
Thanks for starting the effort. Many people stumbled over the […]
The current enumeration may be used to select the default programmer when building, like this:
make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000"
If this enumeration can be deleted, I think it is best.
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/cbd5a40a_64363fdd PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)
This should be run as a recipe for the file. Currently it would be […]
This is a good suggestion. But I have no better solution yet.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/49599/comment/3004eaa0_7233e5a1 PS4, Line 43: #include "programmer_table.c"
.c includes are generally discouraged.
Yes, this may cause some problems. This file has been renamed
-
Xiang Wang (Code Review)