Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer.

View Change

3 comments:

• Patchset:

  • Patch Set #4:

    Thanks for starting the effort. Many people stumbled over the […]

    The current enumeration may be used to select the default programmer when building, like this:
    > make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000"

    If this enumeration can be deleted, I think it is best.

• File Makefile:

  • Patch Set #4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)

    This should be run as a recipe for the file. Currently it would be […]

    This is a good suggestion. But I have no better solution yet.

• File flashrom.c:

  • Patch Set #4, Line 43: #include "programmer_table.c"

    .c includes are generally discouraged.

    Yes, this may cause some problems. This file has been renamed

To view, visit change 49599. To unsubscribe, or for help writing mail filters, visit settings.