Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan, Daniel Campello, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 )
Change subject: cli_classic.c: Make -r/-w/-v argument optional
......................................................................
Patch Set 18:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/52362/comment/9ec47735_85bb460b
PS18, Line 733: for (arg = include_args; arg; arg = arg->next) {
: if (check_filename(arg->file, "region")) {
: ret = 1;
: goto out_shutdown;
: }
: }
Not sure what is the status of this patch, but seems like it needs to be updated because I have just modified this chunk of code in chromium tree: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+... (hope the link is visible to everyone? if not tell me please).
I read the latest few comments, and it not entirely clear to me what is the plan for this patch: complete or abandon?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41
Gerrit-Change-Number: 52362
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 17 Oct 2021 22:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment