Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan, Daniel Campello, Angel Pons.
View Change
1 comment:
File cli_classic.c:
Patch Set #18, Line 733:
for (arg = include_args; arg; arg = arg->next) {
if (check_filename(arg->file, "region")) {
ret = 1;
goto out_shutdown;
}
}
Not sure what is the status of this patch, but seems like it needs to be updated because I have just modified this chunk of code in chromium tree: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/3013419 (hope the link is visible to everyone? if not tell me please).
I read the latest few comments, and it not entirely clear to me what is the plan for this patch: complete or abandon?
To view, visit change 52362. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41
Gerrit-Change-Number: 52362
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 17 Oct 2021 22:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment