Attention is currently required from: Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email )
Change subject: doc: Add new Development guidelines ......................................................................
Patch Set 3:
(10 comments)
Patchset:
PS3: Thanks a lot everyone for reviews! I fixed some comments but not all of them, will continue tomorrow.
Also I added some stuff: Downloading patch from Gerrit and Merge checklist
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/441b7b5a_35c18941 : PS1, Line 5: Intro, is there anything useful to say?
No idea what to put in an introduction, maybe: […]
Angel this is a good idea, thank you I added your intro! I also found some good words in "Documentation" page on wiki, added that as well.
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/6c0be7d5_e76efb13 : PS2, Line 11: *
This is not displayed as a nested list (and same below). Need to be fixed.
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/26dfd5f0_6800c15b : PS2, Line 27: Create a commit and sign-off ``git commit -s``.
This is a good concise summary, but it's kind of confusing with this wording. Perhaps: […]
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/42c3f28b_aa92173d : PS2, Line 119: *
Bullet point lists have different indentation in the doc, and rendered with different indentation in […]
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/fb7a58d2_98304c07 : PS2, Line 141: there
Remove unnecessary word.
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/a9f0fc57_1dba4482 : PS2, Line 216: The only official repository is https://review.coreboot.org/flashrom and GitHub and GitLab are just mirrors.
Slight modification for clarity: […]
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/44ea4c6c_c0725f0b : PS2, Line 221: sending : it to review.coreboot.org.
Link this to the Working With Gerrit heading above?
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/3ee10634_cb64be87 : PS2, Line 279: Except, if a commit
The comma seems rather clunky, how about: […]
I actually removed that word "exception". This is not on exception, it's great when people collaborate!
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/626bec9b_fcfb8945 : PS3, Line 299: :ref:`Team` This page is under review as well, CB:76075
-
Anastasia Klimchuk (Code Review)