Attention is currently required from: Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen.
10 comments:
Patchset:
Thanks a lot everyone for reviews!
I fixed some comments but not all of them, will continue tomorrow.
Also I added some stuff:
Downloading patch from Gerrit
and
Merge checklist
File doc/dev_guide/development_guidelines.rst:
Patch Set #1, Line 5: Intro, is there anything useful to say?
No idea what to put in an introduction, maybe: […]
Angel this is a good idea, thank you I added your intro!
I also found some good words in "Documentation" page on wiki, added that as well.
File doc/dev_guide/development_guidelines.rst:
This is not displayed as a nested list (and same below). Need to be fixed.
Done
Patch Set #2, Line 27: Create a commit and sign-off ``git commit -s``.
This is a good concise summary, but it's kind of confusing with this wording. Perhaps: […]
Done
Bullet point lists have different indentation in the doc, and rendered with different indentation in […]
Done
Patch Set #2, Line 141: there
Remove unnecessary word.
Done
Patch Set #2, Line 216: The only official repository is https://review.coreboot.org/flashrom and GitHub and GitLab are just mirrors.
Slight modification for clarity: […]
Done
sending
it to review.coreboot.org.
Link this to the Working With Gerrit heading above?
Done
Patch Set #2, Line 279: Except, if a commit
The comma seems rather clunky, how about: […]
I actually removed that word "exception". This is not on exception, it's great when people collaborate!
File doc/dev_guide/development_guidelines.rst:
Patch Set #3, Line 299: :ref:`Team`
This page is under review as well, CB:76075
To view, visit change 75906. To unsubscribe, or for help writing mail filters, visit settings.