Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68231 )
Change subject: rayer_spi.c: Move rget_io_perms() check to pre-amble ......................................................................
Patch Set 1:
(1 comment)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68231/comment/86fbe6dd_a1c2db14 PS1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0)
That is a very good question, this maybe subjective patch though so I don't have strong feelings yet […]
The three steps seem reasonable, but i) and ii) seem to be in inverse order. For some programmers, the "permissions&&resource requirements" may not be fully known until the configuration has been checked.
How about:
1) validate and parse programmer configuration, before doing anything, 2) obtain required permissions and resource requirements, before init'ing, 3) do programmer init.
With the ordering suggested above, this little commit isn't needed.
-
Angel Pons (Code Review)