Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.

View Change

1 comment:

• File rayer_spi.c:

  • Patch Set #1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0)

    That is a very good question, this maybe subjective patch though so I don't have strong feelings yet […]

    The three steps seem reasonable, but i) and ii) seem to be in inverse order. For some programmers, the "permissions&&resource requirements" may not be fully known until the configuration has been checked.

    How about:

    1) validate and parse programmer configuration, before doing anything,
    2) obtain required permissions and resource requirements, before init'ing,
    3) do programmer init.

    With the ordering suggested above, this little commit isn't needed.

To view, visit change 68231. To unsubscribe, or for help writing mail filters, visit settings.