Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept ......................................................................
Patch Set 6:
(5 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/414b9a22_9a4fdff1 PS6, Line 30: * - X86_IO_USE_LIBC : * - X86_IO_USE_SWAPPED How about more accurate names, e.g.
USE_LIBC_DESTINATION_LAST USE_LIBC_DESTINATION_FIRST
https://review.coreboot.org/c/flashrom/+/61276/comment/828cffed_36ee389b PS6, Line 33: * - X86_IO_USE_ASM The whole file is about x86-I/O, so I would not repeat that in local identifiers.
https://review.coreboot.org/c/flashrom/+/61276/comment/f5f4e91f_de8b9ecb PS6, Line 51: #define X86_IO_USE_LIBC 1 To be honest, I don't feel good about the indentation. Is there a precedent in flashrom?
https://review.coreboot.org/c/flashrom/+/61276/comment/e7aa34c0_73c1256d PS6, Line 110: #define X86_IO_USE_DOS 1 We could also set aliases for the functions, like for iopl() above, e.g.
#define inb inportb #define outb outportb
Maybe for another patch?
https://review.coreboot.org/c/flashrom/+/61276/comment/c290e359_e0f28732 PS6, Line 259: } The input functions could be shared with USE_SWAPPED. Maybe for another patch?