Attention is currently required from: Thomas Heijligen, Angel Pons.
5 comments:
File hwaccess_x86_io.c:
* - X86_IO_USE_LIBC
* - X86_IO_USE_SWAPPED
How about more accurate names, e.g.
USE_LIBC_DESTINATION_LAST
USE_LIBC_DESTINATION_FIRST
Patch Set #6, Line 33: * - X86_IO_USE_ASM
The whole file is about x86-I/O, so I would not repeat that in local
identifiers.
Patch Set #6, Line 51: #define X86_IO_USE_LIBC 1
To be honest, I don't feel good about the indentation. Is there a
precedent in flashrom?
Patch Set #6, Line 110: #define X86_IO_USE_DOS 1
We could also set aliases for the functions, like for iopl() above, e.g.
#define inb inportb
#define outb outportb
Maybe for another patch?
The input functions could be shared with USE_SWAPPED. Maybe for another
patch?
To view, visit change 61276. To unsubscribe, or for help writing mail filters, visit settings.