David Hendricks has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/19206/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/19206/6//COMMIT_MSG@15 PS6, Line 15: variable.
?
Argh... Should be fixed now.
https://review.coreboot.org/#/c/19206/6/util/getrevision.sh File util/getrevision.sh:
https://review.coreboot.org/#/c/19206/6/util/getrevision.sh@140 PS6, Line 140: return ${EXIT_FAILURE} : fi : : echo "${r}" : } : : is_t
?
Nevermind that last part. I had made some other changes while working on this patch but reverted them to avoid unnecessary diffs. I was thinking that the outer if could be inverted to simplify the logic a bit, but this if-else block is now simple enough.
https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push File util/git-hooks/pre-push:
https://review.coreboot.org/#/c/19206/6/util/git-hooks/pre-push@48 PS6, Line 48: # Check for Signed-off-by and Acked-by
`fi` lost?
D'oh! Amazing that it worked at all. Fixed.
-
David Hendricks (Code Review)