David Hendricks posted comments on this change.
Patch set 8:
(3 comments)
Patch Set #6, Line 15: variable.
?
Argh... Should be fixed now.
return ${EXIT_FAILURE}
fi
echo "${r}"
}
is_t
?
Nevermind that last part. I had made some other changes while working on this patch but reverted them to avoid unnecessary diffs. I was thinking that the outer if could be inverted to simplify the logic a bit, but this if-else block is now simple enough.
Patch Set #6, Line 48: # Check for Signed-off-by and Acked-by
`fi` lost?
D'oh! Amazing that it worked at all. Fixed.
To view, visit change 19206. To unsubscribe, visit settings.