Attention is currently required from: Aarya, Anastasia Klimchuk, Edward O'Callaghan.
Peter Marheine has posted comments on this change by Aarya. ( https://review.coreboot.org/c/flashrom/+/83833?usp=email )
Change subject: programmer.h: Introduce new enum for is_laptop ......................................................................
Patch Set 1:
(2 comments)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/83833/comment/193fae21_a2d6b03d?usp... : PS1, Line 167: enum is_laptop {
I think, it's better to merge two patches together. What do you think? […]
I agree, the changes should be combined. it would be an error to revert just this but not the following change, so it doesn't seem good to make them separate commits.
https://review.coreboot.org/c/flashrom/+/83833/comment/eec14368_bf394e5c?usp... : PS1, Line 168: NO, I think these names should have a prefix, since it would be easy to misuse this for a different application if somebody happened to guess that `NO`/`YES` constants are defined. Possibly `BOARD_IS_LAPTOP_NO`, although that's a bit of a mouthful.
-
Peter Marheine (Code Review)