Attention is currently required from: Aarya, Anastasia Klimchuk, Edward O'Callaghan.
2 comments:
File include/programmer.h:
Patch Set #1, Line 167: enum is_laptop {
I think, it's better to merge two patches together. What do you think? […]
I agree, the changes should be combined. it would be an error to revert just this but not the following change, so it doesn't seem good to make them separate commits.
I think these names should have a prefix, since it would be easy to misuse this for a different application if somebody happened to guess that `NO`/`YES` constants are defined. Possibly `BOARD_IS_LAPTOP_NO`, although that's a bit of a mouthful.
To view, visit change 83833. To unsubscribe, or for help writing mail filters, visit settings.