Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Fix building with meson, again
Change-Id: Iea40da587729f3975a8901d3933e7567805242c5 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M meson_options.txt 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/38659/1
diff --git a/meson_options.txt b/meson_options.txt index b7633d0..ea87311 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -33,3 +33,4 @@ option('config_satasii', type : 'boolean', value : true, description : 'SiI SATA controllers') option('config_serprog', type : 'boolean', value : true, description : 'serprog') option('config_usbblaster_spi', type : 'boolean', value : true, description : 'Altera USB-Blaster dongles') +option('config_stlinkv3_spi', type : 'boolean', value : true, description : 'STMicroelectronics STLINK-V3')
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1: Code-Review+1
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1: Code-Review+2
Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1:
(1 comment)
Thanks for the fix. One cosmetic comment about ordering, though.
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt@36 PS1, Line 36: option('config_stlinkv3_spi', type : 'boolean', value : true, description : 'STMicroelectronics STLINK-V3') The rest of the entries is ordered alphabetically. Can you please push this change one line up?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt@36 PS1, Line 36: option('config_stlinkv3_spi', type : 'boolean', value : true, description : 'STMicroelectronics STLINK-V3')
The rest of the entries is ordered alphabetically. […]
I checked meson.build and placed this in the same position. In any case, it's easier to handle this on a follow-up
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt@36 PS1, Line 36: option('config_stlinkv3_spi', type : 'boolean', value : true, description : 'STMicroelectronics STLINK-V3')
I checked meson.build and placed this in the same position. […]
So, looks like the rest of entries are not 100% alphabetically sorted. Specifically, the order of nicintel stuff is inconsistent between meson.build and this file.
Done in CB:38668
Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1: Code-Review+1
Thanks, makes sense.
Carl-Daniel Hailfinger has submitted this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Fix building with meson, again
Change-Id: Iea40da587729f3975a8901d3933e7567805242c5 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/38659 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: David Hendricks david.hendricks@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net --- M meson_options.txt 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Carl-Daniel Hailfinger: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
diff --git a/meson_options.txt b/meson_options.txt index b7633d0..ea87311 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -33,3 +33,4 @@ option('config_satasii', type : 'boolean', value : true, description : 'SiI SATA controllers') option('config_serprog', type : 'boolean', value : true, description : 'serprog') option('config_usbblaster_spi', type : 'boolean', value : true, description : 'Altera USB-Blaster dongles') +option('config_stlinkv3_spi', type : 'boolean', value : true, description : 'STMicroelectronics STLINK-V3')
-
Angel Pons (Code Review) -
Carl-Daniel Hailfinger (Code Review)
-
David Hendricks (Code Review)
-
Edward O'Callaghan (Code Review)
-
Frans Hendriks (Code Review)