Change in flashrom[master]: meson.build: Align config options with tabs

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/38667 )


Change subject: meson.build: Align config options with tabs
......................................................................

meson.build: Align config options with tabs

Aligned text clearly shows that all options use the same format.

Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Signed-off-by: Angel Pons <[e-mail]>
---
M meson.build
1 file changed, 32 insertions(+), 32 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/38667/1

diff --git a/meson.build b/meson.build
index 375089c..07b89fc 100644
--- a/meson.build
+++ b/meson.build
@@ -30,38 +30,38 @@
 add_project_arguments('-DFLASHROM_VERSION="' + meson.project_version() + '"', language : 'c')
 
 # get defaults from configure
-config_atahpt = get_option('config_atahpt')
-config_atapromise = get_option('config_atapromise')
-config_atavia = get_option('config_atavia')
-config_buspirate_spi = get_option('config_buspirate_spi')
-config_ch341a_spi = get_option('config_ch341a_spi')
-config_dediprog = get_option('config_dediprog')
-config_developerbox_spi = get_option('config_developerbox_spi')
-config_digilent_spi = get_option('config_digilent_spi')
-config_drkaiser = get_option('config_drkaiser')
-config_dummy = get_option('config_dummy')
-config_ft2232_spi = get_option('config_ft2232_spi')
-config_gfxnvidia = get_option('config_gfxnvidia')
-config_internal = get_option('config_internal')
-config_it8212 = get_option('config_it8212')
-config_linux_mtd = get_option('config_linux_mtd')
-config_linux_spi = get_option('config_linux_spi')
-config_mstarddc_spi = get_option('config_mstarddc_spi')
-config_nic3com = get_option('config_nic3com')
-config_nicintel_eeprom = get_option('config_nicintel_eeprom')
-config_nicintel = get_option('config_nicintel')
-config_nicintel_spi = get_option('config_nicintel_spi')
-config_nicnatsemi = get_option('config_nicnatsemi')
-config_nicrealtek = get_option('config_nicrealtek')
-config_ogp_spi = get_option('config_ogp_spi')
-config_pickit2_spi = get_option('config_pickit2_spi')
-config_pony_spi = get_option('config_pony_spi')
-config_rayer_spi = get_option('config_rayer_spi')
-config_satamv = get_option('config_satamv')
-config_satasii = get_option('config_satasii')
-config_serprog = get_option('config_serprog')
-config_usbblaster_spi = get_option('config_usbblaster_spi')
-config_stlinkv3_spi = get_option('config_stlinkv3_spi')
+config_atahpt		= get_option('config_atahpt')
+config_atapromise	= get_option('config_atapromise')
+config_atavia		= get_option('config_atavia')
+config_buspirate_spi	= get_option('config_buspirate_spi')
+config_ch341a_spi	= get_option('config_ch341a_spi')
+config_dediprog		= get_option('config_dediprog')
+config_developerbox_spi	= get_option('config_developerbox_spi')
+config_digilent_spi	= get_option('config_digilent_spi')
+config_drkaiser		= get_option('config_drkaiser')
+config_dummy		= get_option('config_dummy')
+config_ft2232_spi	= get_option('config_ft2232_spi')
+config_gfxnvidia	= get_option('config_gfxnvidia')
+config_internal		= get_option('config_internal')
+config_it8212		= get_option('config_it8212')
+config_linux_mtd	= get_option('config_linux_mtd')
+config_linux_spi	= get_option('config_linux_spi')
+config_mstarddc_spi	= get_option('config_mstarddc_spi')
+config_nic3com		= get_option('config_nic3com')
+config_nicintel_eeprom	= get_option('config_nicintel_eeprom')
+config_nicintel		= get_option('config_nicintel')
+config_nicintel_spi	= get_option('config_nicintel_spi')
+config_nicnatsemi	= get_option('config_nicnatsemi')
+config_nicrealtek	= get_option('config_nicrealtek')
+config_ogp_spi		= get_option('config_ogp_spi')
+config_pickit2_spi	= get_option('config_pickit2_spi')
+config_pony_spi		= get_option('config_pony_spi')
+config_rayer_spi	= get_option('config_rayer_spi')
+config_satamv		= get_option('config_satamv')
+config_satasii		= get_option('config_satasii')
+config_serprog		= get_option('config_serprog')
+config_usbblaster_spi	= get_option('config_usbblaster_spi')
+config_stlinkv3_spi	= get_option('config_stlinkv3_spi')
 
 cargs = []
 deps = []

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-MessageType: newchange

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38667 )

Change subject: meson.build: Align config options with tabs
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Carl-Daniel Hailfinger <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 01 Feb 2020 16:11:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38667 )

Change subject: meson.build: Align config options with tabs
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Carl-Daniel Hailfinger <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Sun, 02 Feb 2020 02:47:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Carl-Daniel Hailfinger (Code Review)]

Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38667 )

Change subject: meson.build: Align config options with tabs
......................................................................


Patch Set 1: Code-Review-1

Please don't.
This adds needless churn, breaks git blame and makes the formatting of the file inconsistent.


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Carl-Daniel Hailfinger <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Sun, 02 Feb 2020 07:05:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38667 )

Change subject: meson.build: Align config options with tabs
......................................................................


Patch Set 1:
> Patch Set 1: Code-Review-1
>
> Please don't.
> This adds needless churn, breaks git blame and makes the formatting of the file inconsistent.

Well, git blame on this rather recent part of the code isn't too critical. What about the reordering of flashchips.c, which also broke git blame? In any case, one can checkout the parent of the offending commit and run git blame on that.

With regard to tabs, would this be better if done with spaces instead?


-- 
To view, visit https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Carl-Daniel Hailfinger <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Sun, 02 Feb 2020 12:38:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/38667 )

Change subject: meson.build: Align config options with tabs
......................................................................


Abandoned
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/38667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idf02cdb57b67d86eec4981b9bd000b197175ec67
Gerrit-Change-Number: 38667
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Carl-Daniel Hailfinger <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon