Attention is currently required from: David Wu, Kapil Porwal, Maximilian Brune, Nikolai Artemiev, Subrata Banik, Tyler Wang.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79088?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashchips: Add GD25LQ255E
......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS9:
Hello Tyler, thank you for the patch! I just have two questions to clarify.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/79088/comment/a8af90df_8fdf85cb :
PS9, Line 6559: FEATURE_WRSR_EXT2
Also for my education: how do I find out from datasheet that FEATURE_WRSR_EXT2 is supported? Thank you!
https://review.coreboot.org/c/flashrom/+/79088/comment/ea7972ba_4a3a3663 :
PS9, Line 6595: 1695, 1950
Just for my education: the datasheet says `Full voltage range: 1.65-2.0V` but you are using slightly different range. Is there a reason for this?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0d780255ed6772f4aa406584acf071a7ddd6da47
Gerrit-Change-Number: 79088
Gerrit-PatchSet: 9
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 16 Dec 2023 10:06:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment