Change in flashrom[master]: Enable dynamic memory allocation checks for cmocka unit tests - flashrom-gerrit

1 Apr 2021


      Attention is currently required from: David Hendricks, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51243 )
Change subject: Enable dynamic memory allocation checks for cmocka unit tests
......................................................................
Patch Set 7:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/51243/comment/af2e565f_3972543d 
PS6, Line 477: -include
...
Ah, sorry. I'm still very used to the comfort and pain of having […]
I am fine with no-spaces, it aligns with -D definitions (like the ones above -DCONFIG_DEFAULT_PROGRAMMER_ARGS="" there is no space between D and the rest).
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c6b6b8dc17aaee28640e3fca3d1fc9f7feabf5f
Gerrit-Change-Number: 51243
Gerrit-PatchSet: 7
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz djkurtz@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-CC: Victor Ding victording@chromium.org
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 01 Apr 2021 00:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment