Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71622 )
Change subject: dmi.c: Pass is_laptop by ref into dmi ......................................................................
Patch Set 4:
(1 comment)
File internal.c:
https://review.coreboot.org/c/flashrom/+/71622/comment/f9e8c81a_5df15687 PS4, Line 31: laptop_ok
Can we start this chain by moving this to `g_laptop_ok`. […]
I am not sure I follow, this commit was to make dmi functional and rename the residual remaining, hard to remove, global's with a `g_` prefix to avoid symbol shadowing. I think you maybe reading the intent in reverse and are asking to first rename all occurrences to `g_` and rebase this on top? But that would just make this patch largely a revert of that.
-
Edward O'Callaghan (Code Review)