Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
View Change
1 comment:
File internal.c:
Patch Set #4, Line 31: laptop_ok
Can we start this chain by moving this to `g_laptop_ok`. […]
I am not sure I follow, this commit was to make dmi functional and rename the residual remaining, hard to remove, global's with a `g_` prefix to avoid symbol shadowing. I think you maybe reading the intent in reverse and are asking to first rename all occurrences to `g_` and rebase this on top? But that would just make this patch largely a revert of that.
To view, visit change 71622. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d5ad6c0623269492d775a99a947fd6fe26c5f91
Gerrit-Change-Number: 71622
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 09 Mar 2023 11:03:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment