Attention is currently required from: Xiang W, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55115 )
Change subject: programmer_table: remove NULL termination ......................................................................
Patch Set 1: Code-Review+2
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55115/comment/3f2975e8_27e58026 PS1, Line 7: NULL lower case `null`, it's not a NULL pointer.
https://review.coreboot.org/c/flashrom/+/55115/comment/e2f0d45a_0a0b3fa0 PS1, Line 9: Object lower case `object`
https://review.coreboot.org/c/flashrom/+/55115/comment/ec19f1dd_ad1c41c6 PS1, Line 9: correspond missing singular s: corresponds
https://review.coreboot.org/c/flashrom/+/55115/comment/ff5cffeb_f7224aab PS1, Line 10: to PROGRAMMER_INVALID has no use in currend code last but not least, missing full stop
https://review.coreboot.org/c/flashrom/+/55115/comment/1c491a59_f89f475d PS1, Line 10: currend current with t
Patchset:
PS1: Not easy to prove, but I've looked through `git grep -24 programmer_table`: For most references the index is explicitly guarded. In some cases the global `programmer` index is used. However, these would dereference actual NULL pointers inside the programmer struct if `programmer == PROGRAMMER_INVALID`. So no trouble there.
-
Nico Huber (Code Review)