Attention is currently required from: Xiang W, Thomas Heijligen, Angel Pons.

Patch set 1:Code-Review +2

View Change

6 comments:

• Commit Message:

  • Patch Set #1, Line 7: NULL

    lower case `null`, it's not a NULL pointer.

  • Patch Set #1, Line 9: Object

    lower case `object`

  • Patch Set #1, Line 9: correspond

    missing singular s: corresponds

  • Patch Set #1, Line 10: to PROGRAMMER_INVALID has no use in currend code

    last but not least, missing full stop

  • Patch Set #1, Line 10: currend

    current with t

• Patchset:

  • Patch Set #1:

    Not easy to prove, but I've looked through `git grep -24 programmer_table`:
    For most references the index is explicitly guarded. In some cases the
    global `programmer` index is used. However, these would dereference
    actual NULL pointers inside the programmer struct if `programmer ==
    PROGRAMMER_INVALID`. So no trouble there.

To view, visit change 55115. To unsubscribe, or for help writing mail filters, visit settings.