Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons. Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 )
Change subject: serprog.c: Avoid calling memcpy with NULL pointer arguments ......................................................................
Patch Set 14:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62726/comment/4474ac52_d00fcf4d PS12, Line 10: Although, since parmlen is also 0 at that time I : don't think it would make much difference.
The function `sp_stream_buffer_op` is used multiple times and also with different values for parmlen […]
I'm not sure I understood you wanted to say here. I am referring to the definition of sp_stream_buffer_op.
https://review.coreboot.org/c/flashrom/+/62726/comment/35d80022_416d67ee PS12, Line 11: Still, add a NULL check before calling memcpy to be safe.
Wrap at 72 chars.
Done
-
Light (Code Review)