Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons.
View Change
2 comments:
Commit Message:
Patch Set #12, Line 10:
Although, since parmlen is also 0 at that time I
don't think it would make much difference.
The function `sp_stream_buffer_op` is used multiple times and also with different values for parmlen […]
I'm not sure I understood you wanted to say here. I am referring to the definition of sp_stream_buffer_op.
Patch Set #12, Line 11: Still, add a NULL check before calling memcpy to be safe.
Wrap at 72 chars.
Done
To view, visit change 62726. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b
Gerrit-Change-Number: 62726
Gerrit-PatchSet: 14
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 04:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Gerrit-MessageType: comment