Attention is currently required from: Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59276 )
Change subject: pcidev: Move pci_get_dev() logic into canonical place ......................................................................
Patch Set 4:
(1 comment)
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/59276/comment/3217e7f2_68070642 PS3, Line 1097: dev = pcidev_clonedev(dev);
Done. np Nico, thanks for thinking about the problem.
Idk. without anything hinting towards "function" 1 in the function name, The code was easier to follow before this change. If I'd read it now, I'd have to look into another file to figure out what it does.
I agree the code is confusing, generally pacc-related paths are hard to follow.
There's one exception but generally I think it's best to think of `pacc` as just the global libpci library handle. Nothing special.
Let's move this forwards to make go in the general right direction.
Honestly, I don't know yet in what direction you are pointing and if that's the right one.
-
Nico Huber (Code Review)