Attention is currently required from: Edward O'Callaghan.

View Change

1 comment:

• File board_enable.c:

  • Patch Set #3, Line 1097: dev = pcidev_clonedev(dev);

    Done. np Nico, thanks for thinking about the problem.

    Idk. without anything hinting towards "function" 1 in the function name,
    The code was easier to follow before this change. If I'd read it now,
    I'd have to look into another file to figure out what it does.

    I agree the code is confusing, generally pacc-related paths are hard to follow.

    There's one exception but generally I think it's best to think of `pacc` as
    just the global libpci library handle. Nothing special.

    Let's move this forwards to make go in the general right direction.

    Honestly, I don't know yet in what direction you are pointing and if
    that's the right one.

To view, visit change 59276. To unsubscribe, or for help writing mail filters, visit settings.