Change in flashrom[master]: libflashrom,writeprotect: add flashrom_wp_{config,range,mode}_to_str()
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58484 )
Change subject: libflashrom,writeprotect: add flashrom_wp_{config,range,mode}_to_str() ......................................................................
Patch Set 26:
(2 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58484/comment/983b5382_d3558d08 PS25, Line 138: arbitrary
It definitely has a minimum. It's hard to get right without leaking […]
I've refactored a bit and we don't need fixed size strings in the libflashrom API now.
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58484/comment/bc0f4cf3_e373b490 PS25, Line 466: }
This leaks internal information, it looks much like debugging code TBH. […]
Ack - I've inlined the {range,mode}_to_str() functions into CLI code and config_to_str() into the range enumeration code.
-
Nikolai Artemiev (Code Review)