Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

2 comments:

• File libflashrom.h:

  • Patch Set #25, Line 138: arbitrary

    It definitely has a minimum. It's hard to get right without leaking […]

    I've refactored a bit and we don't need fixed size strings in the libflashrom API now.

• File writeprotect.c:

  • Patch Set #25, Line 466: }

    This leaks internal information, it looks much like debugging code TBH. […]

    Ack - I've inlined the {range,mode}_to_str() functions into CLI code and config_to_str() into the range enumeration code.

To view, visit change 58484. To unsubscribe, or for help writing mail filters, visit settings.