Attention is currently required from: Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68739 )
Change subject: flashrom_tester: Use tempdir crate for test data ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
File util/flashrom_tester/src/tester.rs:
https://review.coreboot.org/c/flashrom/+/68739/comment/c3fc7ef8_71e17e76 PS5, Line 87: : original_flash_contents: tmp_dir.path().join("flashrom_tester_golden.bin"), : The critical issue with this patch is that it can leave a DUT irrecoverable should the test suite fail in some way or get stopped with no ability to inspect the pre-run state and use that to recover with.
The principle idea behind the patch is good but it needs more care to not regress the requirement of postmortem test analysis of artifacts.