Attention is currently required from: Evan Benn.

Patch set 5:Code-Review -1

View Change

1 comment:

• File util/flashrom_tester/src/tester.rs:

  • Patch Set #5, Line 87:

    
                original_flash_contents: tmp_dir.path().join("flashrom_tester_golden.bin"),
    
    

    The critical issue with this patch is that it can leave a DUT irrecoverable should the test suite fail in some way or get stopped with no ability to inspect the pre-run state and use that to recover with.

    The principle idea behind the patch is good but it needs more care to not regress the requirement of postmortem test analysis of artifacts.

To view, visit change 68739. To unsubscribe, or for help writing mail filters, visit settings.