Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 )
Change subject: cli_classic: Make -r/-w/-v argument optional ......................................................................
Patch Set 1:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/52362/comment/ae6dd7ff_4484f148 PS1, Line 46:
I'm not too familiar with what the design considerations are here, so take this with a grain of salt, but I wonder if there is a way to make the flags more orthogonal. Right now, these two invocations would be equivalent: -r some_file.bin -i some_region -r -i some_region:some_file.bin
These are not the same: the first one will create a ROM size some_file.bin with 0s and the some_region contents, the second one will be some_file.bin sized to the region size.
A third option will create both files with different sizes/contents as above: -r some_ROM_file.bin -i some_region:some_file.bin
One option is to get rid of "-i" completely and make -r/-w/-v repeated with optional region parameters, e.g. something like -r some_file.bin -r some_file.bin:some_region -r some_file.bin:some_region -r some_other_file.bin:some_other_region
But if we need to keep "-i" around, then everything here seems reasonable.
-
Daniel Campello (Code Review)