Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev.

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #1, Line 46:

    I'm not too familiar with what the design considerations are here, so take this with a grain of salt, but I wonder if there is a way to make the flags more orthogonal. Right now, these two invocations would be equivalent:
      -r some_file.bin -i some_region
      -r -i some_region:some_file.bin

    These are not the same: the first one will create a ROM size some_file.bin with 0s and the some_region contents, the second one will be some_file.bin sized to the region size.

    A third option will create both files with different sizes/contents as above:
       -r some_ROM_file.bin -i some_region:some_file.bin

    
    One option is to get rid of "-i" completely and make -r/-w/-v repeated with optional region parameters, e.g. something like
      -r some_file.bin
      -r some_file.bin:some_region
      -r some_file.bin:some_region -r some_other_file.bin:some_other_region

    But if we need to keep "-i" around, then everything here seems reasonable.

To view, visit change 52362. To unsubscribe, or for help writing mail filters, visit settings.